search

voltone / x509

Elixir package for working with X.509 certificates, Certificate Signing Requests (CSRs), Certificate Revocation Lists (CRLs) and RSA/ECC key pairs
BSD 3-Clause "New" or "Revised" License
120 stars 28 forks source link

fix(test_server): deprecated ssl_accept #48

Closed victorolinasc closed 2 years ago

victorolinasc commented 2 years ago

OTP 21 deprecated the :ssl.ssl_accept/3 function. So, we add a compile check to determine which function to call. This library supports Elixir 1.5 and so the OTP support must be present up to OTP 18.

victorolinasc commented 2 years ago

This was breaking on OTP 24 for the test_server mix task :)

voltone commented 2 years ago

Thanks for that, and sorry for the delay. I would actually prefer to avoid apply/3, and instead define a private function that calls either accept or handshake (like here). What do you think?

victorolinasc commented 2 years ago

Fine for me :) Will update accordingly.

victorolinasc commented 2 years ago

Updated!

voltone commented 2 years ago

Updated!

Excellent. Thanks!

Will merge and publish 0.8.5 now.