search

voltone / x509

Elixir package for working with X.509 certificates, Certificate Signing Requests (CSRs), Certificate Revocation Lists (CRLs) and RSA/ECC key pairs
BSD 3-Clause "New" or "Revised" License
120 stars 28 forks source link

chore(Elixir): fix warnings emitted from v1.17.0 #71

Closed tomciopp closed 4 months ago

tomciopp commented 4 months ago

@voltone Let me know if you have any questions.

voltone commented 4 months ago

Thanks for your PR! I just merged #73 and it formats the code using a more recent formatter that uses charlist sigils. I believe that supersedes this PR, am I right?

tomciopp commented 4 months ago

@voltone That PR handles most of the issues, but there are still some charlists in doctests. I can push another PR that just handles those.

tomciopp commented 4 months ago

@voltone There is also a warning thrown by the deprecated, System.get_pid/0 function. However I have left that out of the new PR as it looks like the replacement System.pid has only been around since Elixir version 1.9.0.

voltone commented 4 months ago

@voltone There is also a warning thrown by the deprecated, System.get_pid/0 function. However I have left that out of the new PR as it looks like the replacement System.pid has only been around since Elixir version 1.9.0.

I know, and since it is only used in tests I don't see much reason to drop support for Elixir < 1.9 just for that...

voltone commented 4 months ago

Superseded by #73 and #74