Remove deprecated charlist syntax

voltone / x509

Elixir package for working with X.509 certificates, Certificate Signing Requests (CSRs), Certificate Revocation Lists (CRLs) and RSA/ECC key pairs

BSD 3-Clause "New" or "Revised" License

120 stars 28 forks source link

Remove deprecated charlist syntax #72

Closed whatyouhide closed 5 months ago

whatyouhide commented 5 months ago

As per the title. @voltone I went with ~c'' but I can go with ~c"" too if you prefer that.

voltone commented 5 months ago

Thanks for the PR. Looks like the test server is not working on OTP 27 (also on master). I could not immediately find a reason, going to dig a little deeper tomorrow...

whatyouhide commented 5 months ago

@voltone no worries, there's no rush on my end. I can also remove the 1.17 version from the CI matrix in this PR and scope this to the charlists if you prefer, up to you.

voltone commented 5 months ago

I just merged #73 to support OTP 27. Formatting replaced single quotes with charlist sigils, so I suppose this PR is no longer needed, right?

whatyouhide commented 5 months ago

Correct, thanks!!