use 2 spaces intend and single quote

voltrb / volt

A Ruby web framework where your Ruby runs on both server and client

MIT License

3.22k stars 196 forks source link

use 2 spaces intend and single quote #307

Open dennym opened 9 years ago

dennym commented 9 years ago

Maybe rubocop should be used and also required by CI for green to have some nice unified styling. And not some random patched worked code base.

ryanstout commented 9 years ago

@dennym My plan is to integrate auto-running of rubocop here in a few. I'm going to wait until after I get the sql stuff done so I don't have to deal with related merge conflicts until I have everything back on master.

dennym commented 8 years ago

Could be pretty pain to get the current codebase clean first :) Just got up yesterday and checked all new notifications in github and saw this painful 2 tabs code. Had to change it.

alexandred commented 8 years ago

@dennym that's my code, sorry :) I come from an obscure ruby background where 4 space tabs were the standard in the codebase and I've continued this bad habit for 10 years now :) I've switched my sublime's tab settings to 2 spaces so it shouldn't happen in future PRs from me.