voltrondata-labs / arrow-benchmarks-ci

Benchmarks CI for Apache Arrow project
MIT License
0 stars 5 forks source link

Make debugging benchalerts easier #165

Closed austin3dickey closed 1 year ago

austin3dickey commented 1 year ago

This PR adds some small improvements to make it easier to debug what happened when benchmarks had failures or regressions.

  1. The internal Slack message now points to the PR comment instead of the check run report. (This PR link is now stored in the DB too.)
  2. The check run report now links to public Buildkite build logs.
  3. The PR comment now reports the number of unstable failures+regressions instead of just saying that they exist.
  4. Also fixed a small bug where PR-requested benchmarks returned the wrong check status in some cases.