Ensure that arguments aren't silently eaten + ignored

voltrondata-labs / arrowbench

R package for benchmarking

Other

13 stars 9 forks source link

Ensure that arguments aren't silently eaten + ignored #11

Closed jonkeane closed 3 years ago

jonkeane commented 3 years ago

This has bitten me a few times (and a few others) With this change, passing unknown arguments to a benchmark will fail. I didn't have to change much about how things are run, mostly removed the ... from the setup() step of each (and had to remove our system/global level ones from the list before passing it to setup()

jonkeane commented 3 years ago

I based this on #10 (so I could have GHA check that things were running correctly) so that should merge before this.