search

voltrondata-labs / arrowbench

R package for benchmarking
Other
13 stars 9 forks source link

Fix parentheses/quotation in documents #123

Closed uribo closed 1 year ago

uribo commented 1 year ago

I found this useful package and tried the examples in the README. The following error occurred when executing the code listed in the A (contrived) example section.

Error: unexpected ')' in:
"                     as_data_frame = c(TRUE, FALSE),
                     skip_empty_rows = TRUE))"

This is due to the extra parentheses, which are fixed in this PR. In addition, I have also corrected a forgotten closing of parentheses in the Rd.

jonkeane commented 1 year ago

Thanks for the PR! Those are indeed typos. I'll merge this when the CI is green (not that I expect these changes would make it go red, but just in case there's something up with roxygen)

jonkeane commented 1 year ago

Ha, turns out all that ❌ in CI is related to the new purr and not this PR: 124