search

voltrondata-labs / arrowbench

R package for benchmarking
Other
13 stars 9 forks source link

dependencies: pin duckdb CRAN pkg to 0.7.1-1 #135

Closed jgehrcke closed 1 year ago

jgehrcke commented 1 year ago

From commit msg:

In an attempt to address
https://github.com/apache/arrow/issues/35917
https://github.com/voltrondata-labs/arrow-benchmarks-ci/issues/131

Assumption: the duckdb package move from
0.7.1-1 to 0.8.0 is responsible for result
differences. This patch will help to validate
or invalidate this assumption.

Let's see if this specific version pin breaks the
overall dependency resolution. If it works, we should stay here and have a benchmark owner/author do the investigation for what's required to perform a
duckdb bump.

https://github.com/apache/arrow/issues/35917 https://github.com/voltrondata-labs/arrow-benchmarks-ci/issues/131

I did read https://r-pkgs.org/description.html#sec-description-imports-suggests-minium-version to find the pinning syntax. Of course there's the warning

Since R can’t have multiple versions of the same package loaded at the same time, specifying an exact dependency dramatically increases the chance of conflicting versions2.

but that always holds true. The result is what counts, and we will have to try it out to know the result :).

jgehrcke commented 1 year ago

Got the error

* checking package dependencies ... ERROR
Error: Package required and available but unsuitable version: ‘duckdb’

which isn't really precise. Was the syntax wrong? Could the package not be discovered? Trying <= 0.8.0 instead of == 0.7.1-1.

jgehrcke commented 1 year ago

Mhm. With the last commit pushed I see again 

2023-06-08T10:13:33.1818593Z trying URL 'https://packagemanager.posit.co/cran/__linux__/focal/latest/src/contrib/duckdb_0.8.0.tar.gz'
2023-06-08T10:13:33.8516480Z Content type 'binary/octet-stream' length 3604792 bytes (3.4 MB)

in the build log.

austin3dickey commented 1 year ago

Does duckdb (<= 0.7.1-1) work?

I appreciate the quick temporary fix! If we can get it to work, I'd say we ship it and immediately start looking for a better solution. Version ceilings in R are even more fraught than in python.

jgehrcke commented 1 year ago

Does duckdb (<= 0.7.1-1) work?

pushed a commit to try that!

jgehrcke commented 1 year ago

Huh. Maybe @jonkeane and @alistaire47 should take over from here :)

jonkeane commented 1 year ago

nods yeah this is what @alistaire47 was mentioning about pinning in the R ecosystem.

I'll take a look at the underlying issue and see what I can do.

jgehrcke commented 1 year ago

Closing, @jonkeane helped via https://github.com/voltrondata-labs/arrowbench/pull/136