search

voltrondata-labs / arrowbench

R package for benchmarking
Other
13 stars 9 forks source link

Only run TPC-H scale_factor = 10 when memory >= 64 GB #137

Closed alistaire47 closed 1 year ago

alistaire47 commented 1 year ago

TPC-H query 21 at scale factor 10 has been regularly failing on machines with less than 64 GB of memory, e.g. https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-arm64-t4g-linux-compute/builds/2829#0188b088-42b8-4218-ae4a-93dd0058ce8c As a solution, remove scale_factor=10 permutations using valid_params() when there is insufficient memory.

alistaire47 commented 1 year ago

Closing in favor of https://github.com/voltrondata-labs/benchmarks/issues/141 because labs/benchmarks still uses run_one(), and valid_params() only applies for run_benchmark().