search

voltrondata-labs / arrowbench

R package for benchmarking
Other
13 stars 9 forks source link

Add benchmark for dim.Dataset #24

Closed lidavidm closed 3 years ago

lidavidm commented 3 years ago

In ARROW-9697 I'm working on a count rows method and want to make sure it doesn't regress performance (spoiler alert: it does).

From what I can see, this also needs to be hooked into ursacomputing/benchmarks before conbench will pick it up.

dianaclarke commented 3 years ago

Here's a PR to enable the new case after this merges.

https://github.com/ursacomputing/benchmarks/pull/29/files

lidavidm commented 3 years ago

Thank you! I didn't realize this benchmark had already been mostly hooked up.

lidavidm commented 3 years ago

That's quite interesting syntax, but I'll take it - thanks!