voltrondata-labs / arrowbench

R package for benchmarking
Other
13 stars 9 forks source link

Create a remote dataset benchmark #27

Closed westonpace closed 3 years ago

westonpace commented 3 years ago

Still probably some testing to do here. The sample datasets work ok. I tried collecting the entire dataset (and not specifying any filter/query) but ran into some issues so I want to debug that a bit further.

jonkeane commented 3 years ago

/document

jonkeane commented 3 years ago

Thanks for looking at this + putting this all together. I made a few changes to the structure (and then a bunch of smaller changes to the arrowbench package that I uncovered as I worked on this, which should have been done already, but no time like the present!)

The major things I did was:

westonpace commented 3 years ago

Thanks for cleaning things up @jonkeane . I looked over your changes and it all looks good to me. Simpler and cleaner and it still tests the same thing :)