search

voltrondata-labs / arrowbench

R package for benchmarking
Other
13 stars 9 forks source link

[ENG-3629] Document which dplyr-based queries fail on DuckDB #84

Closed boshek closed 2 years ago

boshek commented 2 years ago

When merged this will close #54

boshek commented 2 years ago

So I'd added a custom grepl function only to find out that grepl is already part of the dev version of the duckdb package: https://github.com/duckdb/duckdb/blob/662041e2b43283bfcfeed984af7c3eaa85fb4996/tools/rpkg/R/backend-dbplyr__duckdb_connection.R#L70-L84

Curious your take but my sense is to drop what is honestly an hacky solution that I came up with and simply wait for the next release on duckdb at which point the existing syntax should just work.

jonkeane commented 2 years ago

So I'd added a custom grepl function only to find out that grepl is already part of the dev version of the duckdb package

Aaaaah, yeah we should definitely just leave as is. It turns out, this is not even actually in a dev version — it's already been released, however it's not yet on CRAN. So once DuckDB 0.3.3 gets to cran these will automagically start working. Maybe add a comment (or we can leave #54 open for now) with a note that we should re-check when 0.3.3 is here?

boshek commented 2 years ago

I'll just keep an eye on CRAN and act accordingly when duckdb 0.3.3 is released.