search

voltrondata-labs / benchmarks

Language-independent Continuous Benchmarking (CB) for Apache Arrow
MIT License
10 stars 11 forks source link

Hotfix: Renamed query in R dataset benchmark #108

Closed alistaire47 closed 2 years ago

alistaire47 commented 2 years ago

I broke things with https://github.com/ursacomputing/arrowbench/pull/106 (specifically here) by changing a query name from count_rows to dims (because it checks number of cols in addition to rows). This PR makes the accompanying change in {benchmarks} so it will pass the right argument.

alistaire47 commented 2 years ago

@austin3dickey The tests are failing here with diffs like 

E         -   --run-name TEXT                 Name of run (commit, pull request, etc).
E         ?                                   ^                        ---------------
E         +   --run-name TEXT                 Free-text name of run (commit ABC, pull
E         ?                                   ^^^^^^^^^^^                  ++++
E         +                                   request 123, etc).
E         +   --run-reason TEXT               Low-cardinality reason for run (commit, pull
E         +                                   request, manual, etc).

which I assume are from your conbench PR. Do you want to do a separate PR to adjust these, or should I fix them in this PR while I'm at it?

austin3dickey commented 2 years ago

Do you want to do a separate PR to adjust these, or should I fix them in this PR while I'm at it?

You can fix them in this PR if it's the fastest way to unblock this.

...I'm not sure why there are so many tests that a help doc from a (non-pegged) dependency tool uses certain wording. Perhaps we shouldn't have those tests in the first place.

alistaire47 commented 2 years ago

...I'm not sure why there are so many tests that a help doc from a (non-pegged) dependency tool uses certain wording. Perhaps we shouldn't have those tests in the first place.

Agreed. There are a lot of things in this package I'd like to clean up if there's time