voltrondata-labs / benchmarks

Language-independent Continuous Benchmarking (CB) for Apache Arrow
MIT License
10 stars 11 forks source link

Use benchclients.ConbenchClient to post benchmarks #136

Closed austin3dickey closed 1 year ago

austin3dickey commented 1 year ago

This PR addresses https://github.com/voltrondata-labs/arrow-benchmarks-ci/issues/121 by overwriting the publish() method that most benchmarks use to post benchmark results to Conbench. It now should use the new benchclients.ConbenchClient, which has more reasonable retrying logic.

jgehrcke commented 1 year ago

Oh, I forgot to comment on this. Thanks for the pragmatic approach. Let's do this, and learn.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5178359122


Changes Missing Coverage Covered Lines Changed/Added Lines %
benchmarks/_benchmark.py 4 8 50.0%
<!-- Total: 4 8 50.0% -->
Totals Coverage Status
Change from base Build 5137100215: -0.2%
Covered Lines: 1526
Relevant Lines: 1748

💛 - Coveralls