Closed westonpace closed 3 years ago
Ok, this is ready for review/merge. The one failing test does not seem to be related. I did add pytest.register_assert_rewrite("benchmarks.tests._asserts")
to conftest.py
because this gave me better output from failed asserts in _asserts.py
but that could be easily reverted if it was wrong.
The async will only be supported on IPC datasets at the moment. It can easily be added to support parquet datasets when ready.
Once available, async will just be the preferred way to run this benchmark. It will not become a proper "parameter".