voltrondata-labs / benchmarks

Language-independent Continuous Benchmarking (CB) for Apache Arrow
MIT License
10 stars 11 forks source link

Revert back to install.packages('arrow') so it fails loudly if extra aren't enabled? #93

Open dianaclarke opened 3 years ago

dianaclarke commented 3 years ago

https://github.com/ursacomputing/benchmarks/commit/d5d21a827dd9560558184de97c5777e7e2581500

We started using nightly because:

FAILED benchmarks/tests/test_file_benchmark.py::test_read_r[parquet, snappy, table]
FAILED benchmarks/tests/test_file_benchmark.py::test_read_r[parquet, snappy, dataframe]
FAILED benchmarks/tests/test_file_benchmark.py::test_read_r[feather, lz4, table]
FAILED benchmarks/tests/test_file_benchmark.py::test_read_r[feather, lz4, dataframe]
FAILED benchmarks/tests/test_file_benchmark.py::test_write_r[parquet, snappy, table]
FAILED benchmarks/tests/test_file_benchmark.py::test_write_r[parquet, snappy, dataframe]
FAILED benchmarks/tests/test_file_benchmark.py::test_write_r[feather, lz4, table]
FAILED benchmarks/tests/test_file_benchmark.py::test_write_r[feather, lz4, dataframe]
Exception: Error: NotImplemented: Support for codec 'snappy' not built

Exception: Error: NotImplemented: Support for codec 'lz4' not built
> install.packages("arrow")
Installing package into '/home/jkeane/R/x86_64-pc-linux-gnu-library/4.1'
(as 'lib' is unspecified)
trying URL 'https://packagemanager.rstudio.com/all/__linux__/bionic/latest/src/contrib/arrow_6.0.0.2.tar.gz'
Content type 'binary/octet-stream' length 20338508 bytes (19.4 MB)
==================================================
downloaded 19.4 MB

* installing *binary* package 'arrow' ...
* DONE (arrow)

The downloaded source packages are in
    '/tmp/RtmpJLf3lB/downloaded_packages'
> arrow_info()
Error in arrow_info() : could not find function "arrow_info"
> arrow::arrow_info()
Arrow package version: 6.0.0.2

Capabilities:

dataset    TRUE
parquet    TRUE
json       TRUE
s3        FALSE
utf8proc   TRUE
re2        TRUE
snappy    FALSE
gzip      FALSE
brotli    FALSE
zstd      FALSE
lz4       FALSE
lz4_frame FALSE
lzo       FALSE
bz2       FALSE
jemalloc  FALSE
mimalloc  FALSE

To reinstall with more optional capabilities enabled, see
   https://arrow.apache.org/docs/r/articles/install.html
jonkeane commented 3 years ago

I'm not sure we want to go back to using only the release in testing. I've actually created a jira in arrow to create some sort of post-release tests to catch things like this — and we will (and have) gotten lots of tickets about it.

Using the nightly will also allow us to add + test benchmark features that aren't in a released version of arrow already.