voltrondata / sqlflite

An example Flight SQL Server implementation - with DuckDB and SQLite back-ends.
Apache License 2.0
209 stars 23 forks source link

Use a proper namespace for this project #46

Closed felipecrv closed 4 months ago

felipecrv commented 4 months ago

Instead of defining symbols inside of the namespace of the projects we use (e.g. arrow). There are two problems with this: risk of nasty linker errors if symbols collide and difficulties in understanding from which project a symbol comes from (is it a class defined in this project or a class from Arrow).

Defining template aliases in headers is not recommended, but for convenience one alias is defined: flight = arrow::flight since we reference this namespace a lot from the code. Many aliases that were defined in .h files are now removed.