search

voltrondata / substrait-r

An R Interface to the 'Substrait' Cross-Language Serialization for Relational Algebra
Other
27 stars 7 forks source link

Update internal substrait version to 0.24.0 #247

Closed thisisnic closed 1 year ago

thisisnic commented 1 year ago

This PR updates the internal substrait version from 0.20.0 to 0.24.0

thisisnic commented 1 year ago

@paleolimbot I tried updating and running inst/update-substrait.R but I'm getting error messages starting with the following:

google/protobuf/any.proto:0:1:File not found.
substrait/extensions/extensions.proto:6:1:Import "google/protobuf/any.proto" was not found or had errors.
substrait/extensions/extensions.proto:77:3:"google.protobuf.Any" is not defined.
substrait/extensions/extensions.proto:80:3:"google.protobuf.Any" is not defined.
google/protobuf/empty.proto:0:1:File not found.
substrait/type.proto:6:1:Import "google/protobuf/empty.proto" was not found or had errors.
substrait/type.proto:192:7:"google.protobuf.Empty" is not defined.
substrait/algebra.proto:6:1:Import "google/protobuf/any.proto" was not found or had errors.
substrait/algebra.proto:7:1:Import "substrait/extensions/extensions.proto" was not found or had errors.

Have I missed a step here? Perhaps something to do with the code next to the comment "This is specific to a homebrew install"?

thisisnic commented 1 year ago

@paleolimbot I can't get the update to update-substrait.R to work for me locally as the directory inst/substrait/proto/google doesn't exist yet

paleolimbot commented 1 year ago

I see https://github.com/voltrondata/substrait-r/tree/main/inst/substrait/proto/google/protobuf ?

thisisnic commented 1 year ago

I see https://github.com/voltrondata/substrait-r/tree/main/inst/substrait/proto/google/protobuf ?

My mistake, got mixed up with nested paths there.