voltrondata / substrait-r

An R Interface to the 'Substrait' Cross-Language Serialization for Relational Algebra
Other
27 stars 7 forks source link

Refactor summarise() to remove extract_aggregations #264

Closed thisisnic closed 1 year ago

thisisnic commented 1 year ago

The implementation of dplyr::summarise() was based on the code from the Arrow R package. The function extract_aggregations() may not be needed, and so should be refactored out.

paleolimbot commented 1 year ago

Was already correct!