Closed GenevieveBuckley closed 2 years ago
Thanks for catching this! Originally I had merge_iou_thr and merge_ioa_thr as changeable parameters before deciding that they were mostly unnecessary for users to tweak. When I removed them from the widget I forgot to update the update_params method.
For now (and unless there's a use case where they need to be changed) I'm just going to leave them hard-coded. Otherwise, I think that making them kwargs would be the way to go.
I pushed a new version (0.1.3) that won't have this problem. Hopefully, it works for you.
I don't have an objection to those values being hard coded (at least, for now I don't think I'm likely to change them).
I've tried out version 0.13 and no longer see the error message, thank you.
I get an error during 3D inference, when the "Run ortho-plane" box is checked.
Steps to reproduce
Error message
Why this error happens, and what we should do about it
This error happens because the
update_params
method for theEngine3d
class is expecting to be passed values formerge_iou_thr
andmerge_ioa_thr
.A better solution might be to use keyword only arguments for update methods. Then if no keyword argument is passed in for a particular kwarg, you could have it fall back on the default value that was provided in the
__init__
and stored as an attribute eg:self.attributename
.There might also be a clearner/nicer solution than this. I'm not sure what the recommended way to update multiple attributes at once is.
Since this affects me, I'm happy to put in a pull request, but we'd need to settle on the approach to take first.