search

volumio / Build

Buildscripts for Volumio System
GNU General Public License v2.0
113 stars 102 forks source link

dhclient mixed with dhcpcd5 #224

Open macmpi opened 7 years ago

macmpi commented 7 years ago

(talking about the client side thing for now, not to confuse with dhcpd server side)

I incidentally stumbled into some coherence issues in Client DHCP services: wireless.js seems to mostly use dhcpcd (although some variable names may refer to the other due to historic reason). However, dhcpcd has no proper systemd service set, as the service file is erroneously named .conf. It has a real .conf file though. On the other hand dhclient has a proper service set and .conf file, but isc-dhcp-client or dhcp3-client are nowhere to be found... Is this mix really intended or historical leftovers?

@earlchew could you help set some coherence and clean-up as per your earlier recommandations? I guess all dhclient related stuff should probably go away, and dhcpcd stuff fine-tuned. Thanks for thoughts.

macmpi commented 6 years ago

Referencing related commit https://github.com/volumio/Build/commit/1028dce149c4010e6cc9550d7c17334812e4aff6

volumio commented 6 years ago

Yes, I am starting to cleanup and fix stuff accordingly...

ashthespy commented 3 years ago

@macmpi this would probably be less relevant with the VolumioOS branch? However wireless.js is something that still needs some work.