Closed ashthespy closed 6 years ago
A quick update. I just updated to node v8.10.0
and rebuilt the node modules listed in Volumio's package.json
The highlights are:
npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated strtok2@1.0.4: depricated, use strtok3 & music-metadata instead
npm WARN deprecated graceful-fs@2.0.3: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
:/volumio$ npm list --depth=0
Volumio2@2.0.0-alpha4 /volumio
+-- album-art@1.0.4
+-- base64-url@1.3.3
+-- body-parser@1.18.2
+-- cache-manager@2.8.0
+-- child_process@1.0.2
+-- compare-versions@3.1.0
+-- compression@1.7.2
+-- connect-busboy@0.0.2
+-- convert-seconds@1.0.1
+-- cookie-parser@1.4.3
+-- cue-parser@0.0.4
+-- ejs@2.5.7
+-- express@4.16.3
+-- fast.js@0.1.1
+-- file-download@0.1.2
+-- firebase@4.12.0
+-- fs-extra@3.0.1 invalid
+-- hashmap@2.3.0
+-- html-entities@1.2.1
+-- inotify@1.4.2
+-- inquirer@3.3.0
+-- ip@1.1.5
+-- is-online@7.0.0
+-- jimp@0.2.28
+-- json-query@2.2.2
+-- kew@0.7.0
+-- libxmljs@0.18.7
+-- linux-mountutils@1.0.2
+-- mdns@2.3.4
+-- mocha@3.5.3
+-- moment@2.21.0
+-- mpd@1.3.0
+-- musicbrainz@0.2.6
+-- musicmetadata@2.0.5
+-- njstrace@0.0.2
+-- node-cache@4.2.0
+-- node-schedule@1.3.0
+-- node-ssdp@3.2.5
+-- node-uuid@1.4.8
+-- nodetools@1.1.4
+-- onoff@1.2.0
+-- pidof@1.0.2
+-- pullr@0.3.2
+-- random-string@0.2.0
+-- serve-favicon@2.4.5
+-- shairport-sync-reader@0.0.6
+-- shelljs@0.7.8
+-- socket.io@1.7.4
+-- socket.io-client@1.7.4
+-- sort-on@2.0.0
+-- spotify-web-api-node@2.5.0
+-- string@3.3.3
+-- tail@1.2.3
+-- telnet@0.0.1
+-- underscore@1.8.3
+-- unirest@0.5.1
+-- v-conf@1.4.0
+-- winston@2.4.1
+-- wireless-tools@0.19.0
`-- yargs@8.0.2
npm ERR! invalid: fs-extra@3.0.1 /volumio/node_modules/fs-extra
Apart from gcc/++ warnings from epoll and libxmljs, it seems that the first step to updating to nodejsv8 was quite painless!
```shell
$ npm install
npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated strtok2@1.0.4: depricated, use strtok3 & music-metadata instead
npm WARN deprecated graceful-fs@2.0.3: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
> epoll@1.0.2 install /volumio/node_modules/epoll
> node-gyp rebuild
make: Entering directory '/volumio/node_modules/epoll/build'
CXX(target) Release/obj.target/epoll/src/epoll.o
SOLINK_MODULE(target) Release/obj.target/epoll.node
COPY Release/epoll.node
make: Leaving directory '/volumio/node_modules/epoll/build'
> grpc@1.10.0 install /volumio/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library
[grpc] Success: "/volumio/node_modules/grpc/src/node/extension_binary/node-v57-linux-arm-glibc/grpc_node.node" is installed via remote
> inotify@1.4.2 install /volumio/node_modules/inotify
> node-gyp rebuild
make: Entering directory '/volumio/node_modules/inotify/build'
CXX(target) Release/obj.target/inotify/src/bindings.o
../src/bindings.cc: In static member function 'static void NodeInotify::Inotify::Callback(uv_poll_t*, int, int)':
../src/bindings.cc:279:34: warning: 'v8::Local
Well,
systemd[1]: Started Volumio Backend Module.
Mar 24 17:36:49 opivol volumio[12342]: module.js:549
Mar 24 17:36:49 opivol volumio[12342]: throw err;
Mar 24 17:36:49 opivol volumio[12342]: ^
Mar 24 17:36:49 opivol volumio[12342]: Error: Cannot find module 'nodetools'
Mar 24 17:36:49 opivol volumio[12342]: at Function.Module._resolveFilename (module.js:547:15)
Mar 24 17:36:49 opivol volumio[12342]: at Function.Module._load (module.js:474:25)
Mar 24 17:36:49 opivol volumio[12342]: at Module.require (module.js:596:17)
Mar 24 17:36:49 opivol volumio[12342]: at require (internal/module.js:11:18)
Mar 24 17:36:49 opivol volumio[12342]: at Object.<anonymous> (/volumio/app/plugins/miscellanea/albumart/albumart.js:9:17)
Mar 24 17:36:49 opivol volumio[12342]: at Module._compile (module.js:652:30)
Mar 24 17:36:49 opivol volumio[12342]: at Object.Module._extensions..js (module.js:663:10)
Mar 24 17:36:49 opivol volumio[12342]: at Module.load (module.js:565:32)
Mar 24 17:36:49 opivol volumio[12342]: at tryModuleLoad (module.js:505:12)
Mar 24 17:36:49 opivol volumio[12342]: at Function.Module._load (module.js:497:3)
Mar 24 17:36:49 opivol systemd[1]: volumio.service: main process exited, code=exited, status=1/FAILURE
Mar 24 17:36:49 opivol systemd[1]: Unit volumio.service entered failed state.
I don't understand the error - given that I have +-- nodetools@1.1.4
in /volumio/node_modules/
.
For some reason downgrading to nodetools@1.0.0
somehow doesn't throw this error, and I have a working Volumio with nodev8.10.0LTS :-)
@volumio If you have some more details/specific tests for the mdns
module - I could test them out.
My box with node v8.10.0 does show up under Multiroom devices, and seems to work without hitches in my preliminary tests.
Give me sometime and I will create a new image with this. So we can release it in the forum for people to test it ;)
So after a few days, I seem to have issues with the playername automatically changing back to Volumio, from volumiodiscovery
Was this the previous mdsn issues you were mentioning?
Actually, this can be a regression, but it's difficult to say, since mdns is very "picky", I never managed to make it as stable as it should be
Hmm, I actually tracked it down to something unrelated to mdns ;-) https://github.com/volumio/Volumio2/pull/1530
Closed as of b9695799c401628b20a6b391dadd773e29c5166a
Copy paste follow up from https://github.com/volumio/Build/issues/259
@ashthespy
@volumio
@piffio
@volumio