search

volumio / Build

Buildscripts for Volumio System
GNU General Public License v2.0
113 stars 102 forks source link

moved 'rm -rf .git' after 'git rev-parse HEAD' #410

Closed makuhama closed 4 years ago

makuhama commented 4 years ago

VOLUMIO_FE_VERSION in /etc/os-release was empty.

Reason:

Folder /volumio/http/www/.git was deleted before git ... rev-parse HEAD

So I moved the deletion after writing version information to /etc/os-release.

In the wake of that I also added rm -rf build/$BUILD/root/volumio/.git saving another 29MiB from the image

ashthespy commented 4 years ago

Umm, I thought I fixed this in 2c26631fe6afa9e01d8447208eb23d25e4e5b8ea

In the wake of that I also added rm -rf build/$BUILD/root/volumio/.git saving another 29MiB from the image

I believe that is there on purpose - it helps with the volumio pull commands

ashthespy commented 4 years ago

Ah, looks like ef5da971c6de39c271b162596aa09378bec8523f broke it..

volumio commented 4 years ago

Thanks for fixing it. As @ashthespy points out we need to retain the /volumio/.git folder , so please remove the line when you remove this .git folder. 29MB are a really great gain in size, let's explore other options to achieve the same result even if we should have taken all possible steps to reduce the size of it via https://github.com/volumio/Build/blob/master/build.sh#L179

volumio commented 4 years ago

Thanks! Why did you close it? it was fine ;)