volumio / Build

Buildscripts for Volumio System
GNU General Public License v2.0
113 stars 102 forks source link

Create userconfig.txt on firstart only on Raspberry devices #472

Closed ashthespy closed 2 years ago

ashthespy commented 3 years ago

Few questions though,

-- Does this script run on every upgrade? Or only on the first time the image is flashed and run? -- Why are we appending, shouldn't it rather check if the file exists and if not create it?

gkkpch commented 3 years ago

When firststart.sh runs after each update, than the use of it for userconfig.txt is mute. Checking and not creating it would be a better approach in that case.

Creating the file was done in the old version of firststart.sh, but perhaps this is not working as well as I thought. Should be a test case for OTA.

For Raspberry only is ok, I use a different approach for kvims and odroids.

ashthespy commented 3 years ago

-- Does this script run on every upgrade? Or only on the first time the image is flashed and run?

Did someone manage to test this out yet?