search

volumio / Build

Buildscripts for Volumio System
GNU General Public License v2.0
113 stars 103 forks source link

Add custom Shairport #481

Closed volumio closed 3 years ago

volumio commented 3 years ago

@volumio As done for upmpdcli, add : https://repo.volumio.org/?dir=Volumio2/Buster/CustomPackages/shairport-sync

IMPORTANT:

ashthespy commented 3 years ago

Are they build differences b/w the official Debian package? or is this for availability?

volumio commented 3 years ago

3 reasons:

ashthespy commented 3 years ago

Got it! For the long-term then would suggest looking at hosting a proper package repo with all custom Volumio packages, instead of the current file repo. That will then make life easier in managing versioning and dependencies. Will also let users update base/security packages from upstream Debian without breaking Volumio's custom bits.

Something like aptly or pulp makes this quite smooth to setup. Something to consider in the future..

volumio commented 3 years ago

@ashthespy that was also my first choice (4 years ago) and I tried both aptly and repepro... It generated a huge amount of side issues and in the end I dropped it preferring the solution of fetching and installing debs... But yeah, somethign we can try again in the future

ashthespy commented 3 years ago

No I completely agree, K.I.S.S, and moreover if it ain't broke don't bother fixing it.. ;-)

volumio commented 3 years ago

Done with: https://github.com/volumio/Build/commit/372bdae0d8df9e9e5bf86bcc195d777db160ca1f

however, for some reasons the custom systemd service is not there in the image.. needs to be further investigated

ashthespy commented 3 years ago

however, for some reasons the custom systemd service is not there in the image.. needs to be further investigated

No investigation required -- just copy in service file as mentioned back in https://github.com/volumio/Build/pull/484#issuecomment-777611820

ashthespy commented 3 years ago

Fixed with #489