volumio / Volumio-WebUI

Volumio's WebUI
volumio.org
GNU General Public License v3.0
111 stars 61 forks source link

Add SSHFS support #67

Closed alhirzel closed 9 years ago

alhirzel commented 9 years ago

I have started the process of implementing SSHFS. I am doing this against v1.5 (because that's the release I started with). The following has been done:

At least the following needs to be done before this can be merged:

To get this working, I did the following starting with a fresh install of v1.5 for the Raspberry PI:

volumio commented 9 years ago

Interesting! But, since we are working now on a new version (based on node js), the current UI will be dropped.Please tell me your username, and I'll add you to dev group, so you can join the development of new webui. Also, the new system will be built with this build script:https://github.com/volumio/Build

Date: Sun, 1 Feb 2015 14:06:42 -0800 From: notifications@github.com To: Volumio-WebUI@noreply.github.com Subject: [Volumio-WebUI] Add SSHFS support (#67)

I have started the process of implementing SSHFS. I am doing this against v1.5 (because that's the release I started with). The following has been done:

WebUI support for adding/removing SSHFS mounts

Testing against v1.5; this works for me on my RaspPI using SSH keys after doing lots of manual steps

At least the following needs to be done before this can be merged:

Update rootfs (see below for info on changes)

Support a password (i.e. support not using SSH keys)

should not be too hard, just haven't looked at it yet

Support options (e.g. arcfour cipher, others)

Any other updates in the documentation/webui

Testing

Rootfs changes

To get this working, I did the following starting with a fresh install of v1.5

for the Raspberry PI:

apt-get update (probably overkill...)

apt-get install sshfs fuse libfuse2 (installs sshfs and libfuse2, and upgrades fuse)

root@volumio:/DEVEL/mywebui# dpkg -l sshfs libfuse2 fuse | tail -n3 ii fuse 2.9.3-15 armhf Filesystem in Userspace ii libfuse2:armhf 2.9.3-15 armhf Filesystem in Userspace (library) ii sshfs 2.5-1 armhf filesystem client based on SSH File Transfer Protocol

added pi to the fuse group

uncommented user_allow_other in /etc/fuse.conf

used ssh-keygen as root to generate /root/.ssh/id_rsa.pub added this public key to the ~/.ssh/authorized_keys file on my server

You can view, comment on, or merge this pull request online at: https://github.com/volumio/Volumio-WebUI/pull/67

Commit Summary

Implement sshfs into the web UI Add SSHFS teaser to the source editing page

File Changes

M
inc/player_lib.php
(34)

M
sources.php
(6)

M
templates/sources.html
(2)

Patch Links:

https://github.com/volumio/Volumio-WebUI/pull/67.patch https://github.com/volumio/Volumio-WebUI/pull/67.diff

— Reply to this email directly or view it on GitHub.

                  =
alhirzel commented 9 years ago

I made my changes just in time, then... lol

My username is alhirzel, I would definitely help by implementing this feature. Thanks!

volumio commented 9 years ago

Great! You can noo see developer's corner.I'll suggest to take a look also at the buildscripts, if you need help. let me know!

Date: Sun, 1 Feb 2015 14:16:37 -0800 From: notifications@github.com To: Volumio-WebUI@noreply.github.com CC: info@volumio.org Subject: Re: [Volumio-WebUI] Add SSHFS support (#67)

I made my changes just in time, then... lol

My username is alhirzel, I would definitely help by implementing this feature. Thanks!

— Reply to this email directly or view it on GitHub.

                  =
alhirzel commented 9 years ago

Where is developer's corner?

volumio commented 9 years ago

https://volumio.org/forum/developer-corner-f30.html Can you see it?

Date: Mon, 2 Feb 2015 12:39:43 -0800 From: notifications@github.com To: Volumio-WebUI@noreply.github.com CC: info@volumio.org Subject: Re: [Volumio-WebUI] Add SSHFS support (#67)

Where is developer's corner?

— Reply to this email directly or view it on GitHub.

                  =
alhirzel commented 9 years ago

Oh on the Forums, got it. Works, thanks!

On Mon, Feb 2, 2015 at 3:53 PM, Volumio notifications@github.com wrote:

https://volumio.org/forum/developer-corner-f30.html Can you see it?

Date: Mon, 2 Feb 2015 12:39:43 -0800 From: notifications@github.com To: Volumio-WebUI@noreply.github.com CC: info@volumio.org Subject: Re: [Volumio-WebUI] Add SSHFS support (#67)

Where is developer's corner?

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/volumio/Volumio-WebUI/pull/67#issuecomment-72535429.

jomo commented 9 years ago

Is there a GitHub repo for the node-based version?

ning-yu commented 9 years ago

Is there a GitHub repo for the node-based version?

Yes, we'll make it public when it's ready for beta testing!

ning-yu commented 9 years ago

@alhirzel @volumio I'm closing this pull request since it sounds like we want to leave this for the next Volumio revision.

jomo commented 9 years ago

Why don't you make the new repo public already? I would love to take a look and maybe contribute as well.

ning-yu commented 9 years ago

Sure, you're welcome to help! I'll send Michelangelo a PM to see if we can give you access to the repo and forum section.

volumio commented 9 years ago

Yes I'll give you access! And I think its time to make the repo public!

jomo commented 9 years ago

:+1: great!

jomo commented 9 years ago

Could you add me to the internal discussion forum? Sorry for spamming this issue, I can't send PMs on the forum :/

volumio commented 9 years ago

Done! We'll also have a meeting in 3 hours! Join us!

jomo commented 9 years ago

Where do I join?

ning-yu commented 9 years ago

@jomo I sent you a forum PM