volumio / Volumio2-UI

Volumio2 Web Based User Interface
http://volumio.org
168 stars 164 forks source link

Update karma to avoid a deprecation warning #697

Closed xipmix closed 4 years ago

xipmix commented 4 years ago

The warning with 0.12.36 was DeprecationWarning: process.EventEmitter is deprecated. Use require('events') instead. It goes away with karma ^1.0, ^2.0 or ^3.0. The system doesn't build with 4.x.

xipmix commented 4 years ago

This is failing on this step

git push --force --quiet "https://${GH_TOKEN}@${GH_REF}" master:dist > /dev/null 2>&1

Is there some way I can check the push will be merged properly ?

xipmix commented 4 years ago

I tried this hack

diff --git a/deploy.sh b/deploy.sh
index 4afb6da..7f84340 100644
--- a/deploy.sh
+++ b/deploy.sh
@@ -24,9 +24,15 @@ git config user.email "info@volumio.org"
 git add .
 git commit -m "Deploy to Dist Branch"

-# Force push from the current repo's master branch to the dist branch for deployment
-git push --force --quiet "https://${GH_TOKEN}@${GH_REF}" master:dist > /dev/null 2>&1
+git remote add origin git@github.com:xipmix/Volumio2-UI.git

+# Force push from the current repo's master branch to the dist branch for deployment
+if [ -n "$GH_TOKEN" ] && [ -n "$GH_REF" ] ; then
+    git push --force --quiet "https://${GH_TOKEN}@${GH_REF}" master:dist > /dev/null 2>&1
+else
+    git push --force origin master:dist
+fi

and did a fresh copy of your dist branch (0ec92b3 Deploy to Dist Branch) The push worked there

+ git push --force origin master:dist
Counting objects: 169, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (164/164), done.
Writing objects: 100% (169/169), 4.89 MiB | 1.41 MiB/s, done.
Total 169 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4), done.
To git@github.com:xipmix/Volumio2-UI.git
 + 0ec92b3...c4edf3e master -> dist (forced update)

so..not sure what's going wrong here.

volumio commented 4 years ago

Thanks!