volumio / Volumio2

Volumio 2 - Audiophile Music Player
http://volumio.org
Other
1.37k stars 315 forks source link

Volumio official Spotify plugin - Spotify Connect #1465

Open dmnc-net opened 6 years ago

dmnc-net commented 6 years ago

User needs/demands

  1. To have connected own Spotify Premium account, to have all playlists and music available ...
  2. and Spotify Connect (protocol) too. In better case Spotify Connect feature shall be in two modes, bound to the user (then you can do remote control from everywhere) or the Discovery mode (remote control from the same network)

Nowadays

Problems/issues (some of them)

Solution Volumio team will implement Spotify Connect into the Volumio official Spotify plugin or made this functionality as a separate but official plugin - based on the Spotify official binary library or with librespot (but don't let user choose, regular user don't want to make a research which lib is more stable and better)


I'm opening this issue in the reference to the #1405 which has been misunderstood and closed.

MateEke commented 6 years ago

Balbuze's volspotconnect is really stable now, it would be nice if official devs would integrate it.

ashthespy commented 6 years ago

@dmnc-net @MateEke I'm working on getting metadata with Volspotconnect2 as well, it needs some fine tuning, but the big parts are in place :-)

volumio commented 6 years ago

@ashthespy great! looking forward for it!

ashthespy commented 6 years ago

It's working -- with some niggles that we would like to sort out before releasing it out into the wild ;-) :-)

I am still having issues getting the first state accepted by the state machine, it gets rejected with:

info: [1517881948860] Received update from a service different from the one supposed to be playing music. Skipping notification.Current webradio Received volspotconnect

This means that until the track changes and new metadata is pushed, Volumio doesn't know that Spotify Connect is playing. I will dig around some more tomorrow, but if you have some pointers, my PR is here

ericct commented 6 years ago

You write the Part 1. (all playlist and music available) is working. I may be missing a setting, but it's rather so-so for me: while I can indeed see my playlists (hence it connects to my Spotify account), I cannot see my albums or my artists. Also, when being on "my playlists", there is the search box on the right. But a search is not at all filtering the "my playlists" view (instead, it makes a standard search into Spotify) - which is rather misleading.

dmnc-net commented 6 years ago

Yes, part 1) is working in the Spotify plugin by Volumio Team (called "spop") this issue is feature request for @volumio to incorporate part 2) to that plugin.

I'm very glad for hard work put in community volspotconnect plugin but I can't agree with "really stable" nowadays, from my point of view some issues are cosmetic, but blocking issue is crucial. My overall feel from this plugin is about 40% of completeness/compatibility.