volumio / Volumio2

Volumio 2 - Audiophile Music Player
http://volumio.org
Other
1.37k stars 316 forks source link

Period in artist name/directory name isn't included #1600

Open maxengel opened 6 years ago

maxengel commented 6 years ago

For example, if I have a directory labeled R.E.M., the contents aren't being evaluated for inclusion in the library. The share is mounted via SMB. It has showed up in previous versions of Volumio, but seems to not be working in the latest update.

xipmix commented 6 years ago

Can you please specify what version, and if you know it, a version that was working? That will hugely narrow down the search space.

maxengel commented 6 years ago

It is not working with version 2.449. I can't say for certain when it was working. If there is a way to rollback the version/downgrade, I'm happy to cycle through versions to find one that does work.

xipmix commented 6 years ago

Thanks that is useful.

Some initial things to check

To do that:

Not sure about rolling back to abitrary earlier images. The url schema is easy to understand; the issue is what the release version numbers were - this does not seem to be recorded anywhere in the project files. Perhaps try this one (the url is a guess, may not work) and leave it at that. http://updates.volumio.org/pi/volumio/2.413/volumio-2.413-2018-06-21-pi.img.zip

xipmix commented 6 years ago

I tested with an NFS mount on 2.413 (see below).

It works ok on artist names that have '.' in them - they show up in the browse->musiclibrary->nas listing and in the artists listing. It does require a 'rescan' and a refresh of the browse page - e.g. navigate to playback and then back to browse.

$ cat /etc/os-release 
PRETTY_NAME="Raspbian GNU/Linux 8 (jessie)"
NAME="Raspbian GNU/Linux"
VERSION_ID="8"
VERSION="8 (jessie)"
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"
VOLUMIO_BUILD_VERSION="d0d14b37ffe8e45861e4e0b9816241fbafb4eb91"
VOLUMIO_FE_VERSION="81c7100e9c7342b16fc9e0ca5908a26771e08c4f"
VOLUMIO_BE_VERSION="645f0e55945bdd625a662a1ee21ba0dfb11bd73e"
VOLUMIO_ARCH="arm"
VOLUMIO_VARIANT="volumio"
VOLUMIO_TEST="FALSE"
VOLUMIO_BUILD_DATE="Thu Jun 21 01:30:10 CEST 2018"

VOLUMIO_VERSION="2.413"
VOLUMIO_HARDWARE="pi"
xipmix commented 6 years ago

After much palaver (we really need to make smb mounting easier) I was able to mount a test smb share, and it too saw the artist folder named j._S.Bach. So the change is probably between 2.413 (june) and 2.449 (august). I'll try to reprocue on 2.449. when I have a bit more time.

xipmix commented 6 years ago

This is a guess but possibly changing the metadata parsing library has produced this issue?

https://github.com/volumio/Volumio2/commit/e295f8e1f3a5559f151550ea7defbfa35ef91a31 https://github.com/volumio/Volumio2/commit/6005e90eb181a7d79c8ff16a2eb096e4606184c4

maxengel commented 6 years ago

Thanks for digging into this. A metadata parsing issue would be logical.

With regards to access, here is the SSH info: volumio@volumio:/mnt/NAS/Media/Acoustic Sounds Super HiRez$ ls B.B. King Elvis Presley Marvin Gaye The Animals The Rolling Stones Bob Dylan Eric Clapton Miles Davis The Beach Boys Counting Crows John Coltrane R.E.M. The Doors

maxengel commented 6 years ago

Interesting wrinkles: I was first trying access to a server running SMB 3.02. When I switched to a server running 2.1, Volumio did find the R.E.M. directory (although when browsing the name was mangled).

I'm going to try using NFS instead and see what happens, but it seems to be an issue with how SMB is implemented.

xipmix commented 6 years ago

You can probably address this by disabling 'name mangling' (see links below) but it will be interesting to see if the NFS mount behaves the same, please let us know.

maxengel commented 6 years ago

NFS performed much better (no mangling, etc.). I'm going to stick with NFS for now since I'm only in a Linux/Mac world anyways.

Also, the mangling only manifested when browsing by directory and not once the metadata had been fetched and the library built. Also, due to the issue with SMB v3+, I'll wait to test fixing mangling until that issue is resolved.