search

volumio / Volumio2

Volumio 2 - Audiophile Music Player
http://volumio.org
Other
1.37k stars 317 forks source link

Cannot Add Single Songs from NAS to Playlist. Cannot Save Web Radio to Favorites. #1690

Open thomastech opened 5 years ago

thomastech commented 5 years ago

Background Info: Version 2.513 on a RPI3 Model B, 16GB SD.
I've re-flashed a new SD card and started over. The problem remains. Plugins: Autostart 1.1.2, 80s80sRadio 1.0.0, Tunein Radio 1.1.0, Youtube Playback 0.0.9, Backup & Restore 0.7.2, GPIO Buttons 0.8.1

Problem Summary:

  1. Cannot add single songs from "MediaServers->NAS" to Playlist. Adding songs to Playlist from "MusicLibrary->NAS" is Ok.

  2. Cannot save web radio stations to favorites. Specifically I tried saving "Tunein Radio" and "80's80's Radio" web stations to "Web Radio->Radio Favourites". I have no problems saving "Volumio Selection" stations to Radio Favourites.

Another user has similar issues adding single songs. See: https://volumio.org/forum/can-add-single-songs-playlist-t11267.html

BTW, after deleting an entry from "Web Radio->Favorite Radios" the web page reverts to the main "Favorites" page. It should stay on "Web Radio->Favorite Radios".

xipmix commented 5 years ago

Great report, thank you for your care and attention. I will try to reproduce.

Are you able to provide a debug log (https://volumio.github.io/docs/User_Manual/Sending_logs_for_troubleshooting.html)? Best would be if you could:

If you have time could you repeat with "MusicLibrary->NAS", so we see the working path in action too.

xipmix commented 5 years ago

I think I can reproduce this on 2.452. I will retest on your version if I get a chance as there has been some recent work on upnp support.

When I connect to MediaLibrary->NAS->nasbox and select a track, it gets added to the playlist.

# browse to the album I want
Jan 01 04:13:24 volumio volumio[843]: info: CURURI: music-library/NAS/nasbox/Van_Morrison/Moondance
# select a track, click the righthand menu to 'add to playlist'
Jan 01 04:13:30 volumio volumio[843]: info: Listing playlists
Jan 01 04:13:32 volumio volumio[843]: info: Pushing Favourites {"uri":"/mnt/NAS/nasbox/Van_Morrison/Moondance/02-Moondance.flac","favourite":false}
Jan 01 04:13:32 volumio volumio[843]: info: Listing playlists
Jan 01 04:13:50 volumio volumio[843]: info: CoreCommandRouter::executeOnPlugin: mpd , handleBrowseUri
Jan 01 04:13:50 volumio volumio[843]: info: CURURI: playlists
Jan 01 04:13:50 volumio volumio[843]: info: Listing playlists
Jan 01 04:13:51 volumio volumio[843]: info: CoreCommandRouter::executeOnPlugin: mpd , handleBrowseUri
Jan 01 04:13:51 volumio volumio[843]: info: CURURI: playlists/Playlist1
Jan 01 04:13:51 volumio volumio[843]: playlists/Playlist1
Jan 01 04:13:52 volumio volumio[843]: An internal error occurred while serving an albumart. Details: Error: ENOENT: no such file or directory, stat '/volumio/app/plugins/miscellanea/albumart/icons/fa-tags.svg'

When I try to go via MediaServers->NAS->folders->(pick an artist)->(pick an album) and add a track to playlist I get only one line in the system log (when I choose the 'add to playlist' option)

Jan 01 04:10:42 volumio volumio[843]: info: Listing playlists

When I try to add the item (not a web radio) to the favourites I get a different error, which is a separate problem.

Jan 01 04:12:13 volumio volumio[843]: info: CoreCommandRouter::executeOnPlugin: upnp_browser , addToFavourites
Jan 01 04:12:13 volumio volumio[843]: info: Error : CoreCommandRouter::executeOnPlugin: No method [addToFavourites] in plugin upnp_browser
xipmix commented 5 years ago

Tested with 2.513, same behaviour observed and little to go on in the logs.

I also tried adding a track to a new playlist, that generated an empty playlist file.

xipmix commented 5 years ago

Did a little hacking of the upnp_browser plugin

diff --git a/app/plugins/music_service/upnp_browser/index.js b/app/plugins/music_service/upnp_browser/index.js
index c9a0ad6..48c7200 100644
--- a/app/plugins/music_service/upnp_browser/index.js
+++ b/app/plugins/music_service/upnp_browser/index.js
@@ -158,6 +158,8 @@ ControllerUPNPBrowser.prototype.handleBrowseUri=function(curUri)

        var response;

+    self.logger.info("CURURI: "+curUri);
+
        if (curUri == 'upnp')
                response = self.listRoot();
        else if(curUri.startsWith("upnp/")){

but it doesn't help me much - the uri for the selected track looks like

upnp/folder/http://192.168.x.y:9000/ContentDirectory/Control@0$1$12$69$70

and I don't see how this gets passed to the code that writes the playlist file. It does seem like adding tracks to a playlist is not fully implemented for the UPNP (Media Server) music source type.

xipmix commented 5 years ago

Workaround: adding a track to the play queue is supported, so I tried adding a track to the queue and saving the queue as a playlist. That much works.

But when I try to use that playlist I hit problems (version 2.513).

thomastech commented 5 years ago

@xipmix Thanks for reporting your investigation; It appears you're duplicating the reported problem.

I'm new to Volumio and unfamiliar with its support community. So pardon my naivety, but are there official developers that actively monitor the github issues and do bug fixes?

xipmix commented 5 years ago

I'm new to Volumio and unfamiliar with its support community.

The main developer is @volumio, there seem to be a couple of other people who have commit access (not me). The forums might be a good place to learn about this - https://volumio.org/forum/

thomastech commented 5 years ago

Thank you for the developer info. Hopefully @volumio lends a hand with this issue.