volumio / Volumio2

Volumio 2 - Audiophile Music Player
http://volumio.org
Other
1.37k stars 315 forks source link

Remove volume controls when Mixer is disabled #547

Open amalic opened 8 years ago

amalic commented 8 years ago

I am using a Durio DAC. AFAIK hardware volume control is not supported by this DAC with Volumio. Since the volume control on the playback screen is useless, it should not be shown or it should at least stay at 100%.

youpilai commented 8 years ago

Another user of Durio Dac, so i'm in for this improvement. For now, i've edited the webUI files to achieve this goal, but i've to redo it every time there is an update. (not so boring, but still..)

edit: Perhaps a "None" option in the "Mixer Control" entry of Playback Options that trigger some changes in the UI will do the trick. But it implies case test in the "app-XXXXX.js" file to make the volume control appears or not and a slightly change in the corresponding CSS file. I don't know if there is a simple way to implement that

volumio_nosound

apinner commented 8 years ago

Sorry, but that looks awful!

I'm not sure what the answer is here.. Compromising the UI to hide it doesn't seem right when you could just ignore it. I'm not sure what harm is does being there even if it doesn't work.

We could maybe give it a disabled state so it looks like the playback knob when web radio is playing.

amalic commented 8 years ago

On my mobile phone it looks better without any volume control. But for full size screens I agree, that it will look better with disabled controls.

I'm still waiting for my 7inch Raspberry PI touchscreen to arrive from china. Curious how the Volumio2 UI will look on this display sjnce it has a resolution of only 800x480.

I can imagine that removing the volume controls might be necessary for this display.

mooop12 commented 7 years ago

@apinner That looks awful, but the non-functioning volume control that's just staring at you is okay? HiFiBerry Digi+ user here, I'm also annoyed by the volume control and would like a way to disable hide it.