search

volumio / Volumio2

Volumio 2 - Audiophile Music Player
http://volumio.org
Other
1.37k stars 315 forks source link

Plugin deinstallation leaves config behind #905

Closed jo-me closed 7 years ago

jo-me commented 7 years ago

After uninstalling a plugin, the config file(s) of the plugin under /data/configuration are not removed.

The method PluginManager.prototype.removePluginFromConfiguration() removes only the in-memory configuration of the plugin but not the files.

Aside from the residue this might cause sideeffects when reinstalling plugins .

jo-me commented 7 years ago

Associated forum thread: https://volumio.org/forum/plugin-config-file-remains-after-uninstall-t5281.html

jo-me commented 7 years ago

Another plugin deinstallation related issue is here https://github.com/volumio/Volumio2/issues/851

macmpi commented 7 years ago

Last I checked, it seemed plugin configuration folder was not removed upon uninstall. Has this been fixed?

macmpi commented 6 years ago

fixed with https://github.com/volumio/Volumio2/commit/e512b5064eff470f696d69612fb11e859d020d92: thanks!