search

volumio / volumio-plugins-sources

Volumio plugins source code for Volumio 3
47 stars 253 forks source link

feat(spotify): show all favorite tracks and albums #259

Closed phts closed 1 year ago

phts commented 1 year ago

Done for:

Also fixed related issue with failing API requests with "Too many requests" error, because now it gets track info for all tracks in library. Introduced a way to stop sending API requests and wait for some time to be saved from Spotify web API's rate limits.

volumio commented 1 year ago

Really nice work you did. Pretty cool coding on your end, well done

volumio commented 1 year ago

@phts one downside of the sorting you applied is that now the tracks (my tracks) are shown in a very different order than what they used to be and how spotify showed them. would you mind reverting the sorting?

phts commented 1 year ago

@phts one downside of the sorting you applied is that now the tracks (my tracks) are shown in a very different order than what they used to be and how spotify showed them. would you mind reverting the sorting?

@volumio , that's because Spotify's sorting is kind of wrong, because it sorts only by one parameter, and tracks under one artist sorted in a strange order.

My sorting is more user friendly.

BTW I noticed here it used to have return a.tracknumber > b.tracknumber ? 1 : a.tracknumber === b.tracknumber ? 0 : -1; where tracknumber always undefined because not presented in the objects. Those presented in my fork, I accidentally included this into PR here by mistake. But shouldn't be a problem.

Anyways - here you go #269