search

volumio / volumio-plugins-sources

Volumio plugins source code for Volumio 3
43 stars 243 forks source link

Music Your Brand (myb) plugin #330

Closed bitroadie closed 2 months ago

balbuze commented 2 months ago

hello, in install.sh, remove

sudo apt-get update
# Install the required packages via apt-get
sudo apt-get -y install

as you install nothing in package.json, remove 'i386', not used anymore. why spotify package.json in your PR? Please remove it TY

lucaconiglio-bitroadie commented 2 months ago

hello, in install.sh, remove

sudo apt-get update
# Install the required packages via apt-get
sudo apt-get -y install

as you install nothing in package.json, remove 'i386', not used anymore. why spotify package.json in your PR? Please remove it TY

everything fixed, thanks

volumio commented 2 months ago

1 More thing: Are you sure you want the prettyName to be myb and not Music Your Brand?

If yes, let us know and we go ahead and publish it @balbuze

balbuze commented 2 months ago

and don't forget to remove from install.sh


 Install the required packages via apt-get
sudo apt-get -y install
lucaconiglio-bitroadie commented 2 months ago

we changed the pretty name and removed from install.sh: "Install the required packages via apt-get sudo apt-get -y install". Thank you

balbuze commented 2 months ago

I pushed your plugin in beta. But the one you submitted is not the same than in this PR... Please update files, version, re submit and new PR ty