search

volumio / volumio-plugins-sources

Volumio plugins source code for Volumio 3
46 stars 249 forks source link

UI issue: bandcamp search in manifest UI #39

Closed crieke closed 2 years ago

crieke commented 2 years ago

@patrickkfkan Hi Patrick, I've noticed (after merging the bandcamp discover plugin) issues with the manifest UI when using the search function. Can you look into this?

patrickkfkan commented 2 years ago

Hi Chris, it appears to be the same issue as browsing inside the plugin with the titles looking funny under Manifest UI. The visual glitch just looks way worse in the search results.

The plugin (along with Soundcloud, Jellyfin...) displays "rich" titles by including links and image icons in a hacky way not contemplated for by Volumio. It works with the Contemporary UI because I put much effort into making sure the titles look nice.

Now with the Manifest UI, I am not so sure if the same result could be achieved. The UI places anchor points in the browse results and uses list titles as the anchor Id. The "rich" titles would break the UI because they are not plain text but HTML code.

So, in order to ensure that the plugins don't break visually, I would have to revert to plain text titles for the Manifest UI. Unfortunately, this also means users browsing under this UI will not have access to any additional features provided for by the "rich" titles displayed under the old Contemporary UI.

volumio commented 2 years ago

@mervinderuiter can we set up a way to filter out "rich titles" on Manifest?

otherwise, I would say @patrickkfkan it would be better to revert to plain text unitl we find a solution

patrickkfkan commented 2 years ago

can we set up a way to filter out "rich titles" on Manifest?

No. It's not appropriate since rich titles were not meant to be supported in the UI.

I will revert to plain text titles when Manifest is enabled. I've already done that with the Jellyfin and SoundCloud plugins. Will do the same for Bandcamp and Mixcloud.

patrickkfkan commented 2 years ago

Done - https://github.com/volumio/volumio-plugins-sources/pull/46#issue-1076892325