volumio / volumio-plugins

165 stars 750 forks source link

Uninstalling spotify plugin will not work when spopd is not running #148

Closed dmth closed 6 years ago

dmth commented 6 years ago

When spopd is not runnig, one cannot uninstall the spotify plugin.

When uninstalling, the code tries to killall spopd processes, end exists if this is not successfull: https://github.com/volumio/volumio-plugins/blob/master/plugins/music_service/spotify/index.js#L225

Ugly-Quick-fix when you run into this problem:

# log in with ssh
systemctl stop volumio.service
# open with $editor (nano, vim, ...)
$editor /data/plugins/music_service/spop/index.js
# goto line L224 and convert error to !error
# save and exit
cd /volumio
node index.js
# now wait until the system settles and use the web-ui to uninstall the plugin.
dmth commented 6 years ago

Nice! This was already fixed 3hrs ago: https://github.com/volumio/volumio-plugins/commit/b087762cc642fb7628eac52f2e286606455a1257

dmth commented 6 years ago

As the issue is fixed, I'm closing it. Unfortunately I could not update the plugin to the fixed version, I guess due to the same error.