search

volumio / volumio-plugins

164 stars 754 forks source link

volspotconnect2 librespot bug #302

Open worleydl opened 5 years ago

worleydl commented 5 years ago

Recently spotify changed something on their end that breaks the ability to change tracks in librespot. The issue has been addressed in https://github.com/librespot-org/librespot/pull/291

I've built the latest version of librespot and deployed on my pi zero and it resolves the issue, updating the builds in https://github.com/balbuze/volumio-plugins/raw/master/plugins/music_service/volspotconnect2/arch/ should fix this.

balbuze commented 5 years ago

Yes. But volspotconnect 2 uses a custom version of librespot in order to get metadata, hw volume control...@ashthespy seems to work on that to update it. It will be published when ready.

ashthespy commented 5 years ago

Sorry guys, I am on vacation - will try to push changes shortly. EDIT: It's done https://github.com/balbuze/volumio-plugins/issues/209#issuecomment-466861354

volumio commented 5 years ago

Thanks @ashthespy

PS: Is there a way we could use Volumio's REST APIs for volume changes? At least as an option to enable in librespot...

ashthespy commented 5 years ago

@volumio sure can be done - but I don't see a way to do it with librespot in its current form. It could be done by running a small shell script on any volume events.

volumio commented 5 years ago

@ashthespy that will do. Can you add that? Ideally we would need 2 events: getVolume and setVolume, I will take it from there then ;)

ashthespy commented 5 years ago

@volumio On thinking more about this, I realised this is already implemented - volspotconnect2 uses the event along with volumioupdatevolume to set the UI's volume.