volumio / volumio-plugins

165 stars 751 forks source link

Volumio 3 porting for status2mqtt #647

Open fherbet opened 2 years ago

fherbet commented 2 years ago

@jit06

i assume that current status2mqtt plugin will not work with volumio 3.x. can you please confirm ?

is there a chance that this is being worked on so that we can continue using that plugin and profit from Volumio3 as well ? thanks in advance!

jit06 commented 2 years ago

Hi,

I'm absolutely unable to answer your question. I have to test that, but I don't have the time right now.

I'm using all 3 plugins I created for my own volumio. As I'm going to update to volumio 3 sooner or later, I will have to update my plugins, so everyone will be able to enjoy them also 😁

I just can't tell you when I will update them, but I may do that in the next couple of months

fherbet commented 2 years ago

thanks for your answer @jit06 !

glad to see there's still someone behind this plugin !

i will then upgrade to Volumio 3 and do some testing too

then i'll see whether i still see that weird behavior described here > https://github.com/volumio/volumio-plugins/issues/615

fherbet commented 2 years ago

So i just manually installed status2mqtt plugin as described here

Here are the logs, it looks fine .... it is working like with 2.x

sudo apt-get update
sudo apt-get -y install build-essential
cd ~
wget http://plugins.volumio.org/plugins/volumio/armhf/user_interface/status2mqtt/status2mqtt.zip
mkdir status2mqtt
miniunzip status2mqtt.zip -d ./status2mqtt
cd status2mqtt

volumio@volumio:~/status2mqtt$ npm install --save onoff@6.0.0

> epoll@4.0.1 install /home/volumio/status2mqtt/node_modules/epoll
> node-gyp rebuild

make: Entering directory '/home/volumio/status2mqtt/node_modules/epoll/build'
  CXX(target) Release/obj.target/epoll/src/epoll.o
  SOLINK_MODULE(target) Release/obj.target/epoll.node
  COPY Release/epoll.node
make: Leaving directory '/home/volumio/status2mqtt/node_modules/epoll/build'
npm WARN status2mqtt@1.0.1 No repository field.

+ onoff@6.0.0
added 6 packages from 12 contributors and audited 140 packages in 21.528s

5 packages are looking for funding
  run `npm fund` for details

found 9 vulnerabilities (3 low, 1 moderate, 4 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

volumio@volumio:~/status2mqtt$ volumio plugin install

This command will install the plugin on your device

Compressing the plugin
Plugin succesfully compressed
Progress: 10
Status :Télécharger le plugin
nloading plugin at http://127.0.0.1:3000/plugin-serve/status2mqtt.zip
Progress: 30
Status :Création de l'emplacement de destination
Création de l'emplacement de destination
Progress: 40
Status :DĂ©compression du plugin
DĂ©compression du plugin
Progress: 45
Status :Checking that the plugin is suitable for this version of Volumio The plugin has no node version dependency information. The plugin has no Volumio version dependency information. The plugin may not work on this version of Volumio
Checking that the plugin is suitable for this version of Volumio The plugin has no node version dependency information. The plugin has no Volumio version dependency information. The plugin may not work on this version of Volumio
Progress: 50
Status :VĂ©rification des doublons
VĂ©rification des doublons
Progress: 60
Status :Copie du plugin Ă  destination
Copie du plugin Ă  destination
Progress: 70
Status :Installation des utilitaires nécessaires
Installation des utilitaires nécessaires
Progress: 70
Status :Installation des utilitaires nécessaires
Installing status2mqtt Dependencies
Progress: 70
Status :Installation des utilitaires nécessaires
Hit:1 http://raspbian.raspberrypi.org/raspbian buster InRelease
Progress: 70
Status :Installation des utilitaires nécessaires
Hit:2 http://archive.raspberrypi.org/debian buster InRelease
Progress: 70
Status :Installation des utilitaires nécessaires
Hit:3 https://deb.nodesource.com/node_14.x buster InRelease
Progress: 70
Status :Installation des utilitaires nécessaires
Reading package lists...
Progress: 70
Status :Installation des utilitaires nécessaires
Reading package lists...
Progress: 70
Status :Installation des utilitaires nécessaires
Building dependency tree...
Progress: 70
Status :Installation des utilitaires nécessaires
Reading state information...
Progress: 70
Status :Installation des utilitaires nécessaires
0 upgraded, 0 newly installed, 0 to remove and 7 not upgraded.
Progress: 90
Status :Finalisation de l'installation
Finalisation de l'installation
Progress: 100
Status :Status2mqtt Installé avec succÚs, Voulez vous activer ce plugin maintenant ?
Finalisation de l'installation
Done! Plugin Successfully Installed

so i guess this plugin doesn't meed much to be ported officially to 3.x

but i can also confirm that this issue is still there #615

it's working fine for local files / playlist but for webradio, it's always behind 1 status (previous radio is shown unless you play/pause/toggle)

any ideas @jit06 ?

thanks for your help!

jit06 commented 2 years ago

Hello,

I tried to install from source on my freshly updated Volumio3 and it works without touching one line of code. But I think that the zip file from volumio2 cannot work because npm modules are probably linked to libraries that have been updated on volumio 3.

Here is the package I created from my volumio3 status2mqtt.zip

fherbet commented 2 years ago

@jit06

i have tested your zip package following previous steps and it works fine ! thanks

i think it can now be published in Volumio 3 Plugin list (don't know how but i guess it's not an issue for you !)

thanks very much for your nice plugin !!!

btw can you please give your view on #615 and try to reproduce the issue by playing webradios ?

it's working fine for local files / playlist but for webradios, it's always behind 1 status (previous radio is shown unless you play/pause/toggle)

thanks a lot!