volumio / volumio3-backend

Other
32 stars 41 forks source link

Fix/updating status prefetching song #192

Closed Aoblu87 closed 3 months ago

Aoblu87 commented 3 months ago

I removed part of the code because the conditions caused the process to enter a strange loop. By removing this part of the code, the track, cover, and info updates for the next track, now work correctly on Spotify, Qobuz, and Tidal. Volume and seek updates are correct as well

Darmur commented 3 months ago

does gapless playback still work after removing that part of code that handles pre-fetch (even if it's most probably buggy)?

Aoblu87 commented 3 months ago

The tests conducted so far have not given me any errors, meaning the track updates correctly for both the album art and the info in Spotify (which did not show the problem), Tidal, and Qobuz, which had the issue of incorrect synchronization. The tests conducted included:

None of these cases showed any errors

Darmur commented 3 months ago

my question was about gapless playback, does it still work?

Aoblu87 commented 3 months ago

I misunderstood the meaning of gapless playback and checked another aspect of the player. I would need a direct comparison with you to better understand the functionality of gapless playback.

Aoblu87 commented 3 months ago

I found a malfunction with the 'repeat one' function. I’m closing the PR to investigate