enable "Restart=on-failure" for shairport-sync

[joshuahhh]

I've run into a scenario which crashes shairport-sync.

1. Connect to Volumio AirPlay from two devices.
2. Play audio from both devices.

As seen in this log, this crashes shairport-sync with a segfault. Currently, nothing starts it back up except a reboot. With this configuration change, shairport-sync will automatically restart. (Presumably there's some bug in shairport-sync itself, but I'm less interested in fixing that than I am in making Volumio robust to it.)

Please let me know if there's anything else I can do to help. Thanks so much!

[Darmur]

@volumio can we check this? it looks legit

[volumio]

Yeah, looks right on point.

@joshuahhh one futher point of improvement, which we generally do, is adding a delay to restart the service, so it doesn't get stuck in an endless restart loop. We can merge if you could add:

RestartSec=3

to the systemd unit

thanks a lot!

[ashthespy]

which we generally do, is adding a delay to restart the service, so it doesn't get stuck in an endless restart loop.

FWIW: RestartSec will just add a delay between each restart attempt. It doesn't limit the number of restarts. Considering using StartLimitIntervalSec along with StartLimitBurst instead.

This ensures the service is launched a defined number of times, before stopping the service. So a faulty config or something doesn't end up in an endless restart loop..

[joshuahhh]

I've moved away from using Volumio in the last 18 months, but you're welcome to take over this PR. Thanks.

[ashthespy]

I've moved away from using Volumio in the last 18 months, but you're welcome to take over this PR. Thanks.

Thanks for your efforts, good luck out there! :-)

[volumio]

@ashthespy why closed? can't we merge it and add your suggestions contextually?