search

volumio / volumio3-os

GNU General Public License v2.0
61 stars 40 forks source link

NodeJS v14 EOL #70

Closed ashthespy closed 5 months ago

ashthespy commented 1 year ago

14.xx is EOL as of 30-04-2023.

While Node v16 would have been the smart bet, it will be EOL soon after (Bringing forward the End-of-Life Date for Node.js v16)

Would suggest jumping to Node v18. This would entail creating new node_modules bundles.

timothyjward commented 1 year ago

v18 or even v20 seems like the sensible choice.

volumio commented 1 year ago

I agree to go 18 or 20

But we need help with the plugin crypter. @ashthespy would you be able to help there?

timothyjward commented 1 year ago

We should also take this opportunity to update to the latest kew library version, and then start removing kew from the codebase. Native promises are part of Node now and will be a much better option for development (performance, interoperability, support of async/await...)

ashthespy commented 1 year ago

Native promises have been in nodejs for quite a while and async/await in Node v8.x, so you could start refactoring already..

But I agree, modernizing the code base will go a long way towards more maintainable system.

ashthespy commented 1 year ago

FWIW, v16 is also EOL now, so v20 (supported until 2026) would be the logical choice to upgrade to at this point in time.

ashthespy commented 5 months ago

Closing in favor of #172