voluntree-uk / app-next

NextJS Application for Voluntree
https://platform.voluntree.net
1 stars 0 forks source link

Linking and routing #53

Closed alexomon018 closed 3 months ago

alexomon018 commented 1 year ago

I have noticed that there is a use of the chakra Link component to navigate between pages. Chakra link is fine as long as it is wrapped in the next link (https://nextjs.org/docs/api-reference/next/link) which is recommended way of client-side transitions between routes.

mika018 commented 3 months ago

I checked all the instances where chakra <Link> is used and in all of the cases they are either:

The only exceptions are all the links in the footer. The footer is just a placeholder atm and needs a complete rewrite, we have a separate ticket to track that, see #40. I made an explicit reminder there not to use chakra links with href.

I think this is safe to close now