Basis Set Parsers and Test File

vonDonnerstein / QuantumLab.jl

A workbench for Quantum Chemistry and Quantum Physics in Julia

Other

52 stars 19 forks source link

Basis Set Parsers and Test File #11

Open sasadada opened 6 years ago

coveralls commented 6 years ago

Coverage remained the same at 89.592% when pulling 1a67d0d829d9e6389f4356838fae9ee7a2db19c6 on sasadada:master into 723e72556915448b7ad24776eef0b9719bbac646 on vonDonnerstein:master.

vonDonnerstein commented 6 years ago

Hi Ivan, Thanks for your pull request. I've reviewed your code (see above). Maybe you could have a look? Your changes introduce two new files at the base of the git directory instead of modifying the corresponding files in src/Submodules (see "Files changed" tab). Was this intentional or did you mean to update the original files in src/Submodules?

sasadada commented 6 years ago

Hi Henry, I've gone over your suggestions and will work on applying the changes as soon as possible. I did mean to update the original files, thanks for pointing that out.

vonDonnerstein commented 6 years ago

Hi Ivan, are there still changes you wanted to make? I assume you don't want to spend too much more time on this project, so if not, I would suggest you just add tests for your functionalities to test/runtests.jl. This is to make sure neither I, nor anyone else working on your stuff in the future unintentionally breaks them. I could then take it from here, doing the last few changes myself if you like.

vonDonnerstein commented 6 years ago

Also, it would be great, if you could make sure to have Allow edits from maintainers checked on the right of this conversation. Thanks.