search

vonDonnerstein / QuantumLab.jl

A workbench for Quantum Chemistry and Quantum Physics in Julia
Other
51 stars 19 forks source link

Make it run Julia 0.5 #5

Closed jiahao closed 7 years ago

jiahao commented 7 years ago

I found out about this package at the Julia Manchester workshop today. Very interesting :)

Here is a PR to make the code run on Julia 0.5, which was released officially today.

It almost works, but not quite. the Documenter module is broken because Base.doc! changed and I don't really understand enough about what your module is supposed to be doing in order to understand what needs to be changed.

Also normalize whitespace: expand tabs, strip DOS ^M junk

vonDonnerstein commented 7 years ago

Very cool! Thank you for your efforts. I'll be back from a conference I'm attending by Friday next week. Then I'll try to fix the last bits up asap. The results of the test run make it seem to me like there is something we rely on in TensorOperations.jl which also still needs to be updated to j0.5. So maybe it will need a few days but I'm going to pull as soon as I can.

jiahao commented 7 years ago

TensorOperations.jl is fixed on master and perhaps we can ask @Jutho to tag a new version

Jutho commented 7 years ago

There are actually a few bugs that need to be fixed/updated for 0.5 as soon as you use TensorOperations.jl in conjunction with SubArrays. I'll try to fix asap (and then tag a new version) but this week will be very busy for me. I hope to find some time next week.

Jutho commented 7 years ago

I did actually tag a new version yesterday (since I also needed it myself :-) )

vonDonnerstein commented 7 years ago

Alright, I finally found the time to correct the DocumentationModule stuff for j0.5 and merge your commit, @jiahao. Thank you very much again. Also thanks to @Jutho for your work on TensorOperations.jl. It all seems to run through now. (Just that TravisCI still sees j0.4.7 as latest release, but that will probably get solved with time.)