search

vonDonnerstein / QuantumLab.jl

A workbench for Quantum Chemistry and Quantum Physics in Julia
Other
51 stars 19 forks source link

use version number instead of release in .travis.yml #8

Closed tkelman closed 4 years ago

tkelman commented 7 years ago

release will change over time, but your REQUIRE file says this package supports julia 0.5 so it should continue to be tested

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.08%) to 92.317% when pulling a12d0f180864ea05deace37792173db3ef7033f2 on tkelman:travisver into 7128cbc0593c79df972b751f91cd68a223d6a69e on vonDonnerstein:master.

vonDonnerstein commented 6 years ago

That's a valid point. I guess .travis.yml and REQUIRE really should be consistent. I think I would prefer the other way around, however. My take was always that QuantumLab should only support the current stable julia release at any point in time. So I definitely want travis to fail when a new julia version is released but the codebase of QuantumLab has not yet been updated, but not when an older version is no longer supported.

Is there a way to REQUIRE the most current version of julia?

tkelman commented 6 years ago

No, REQUIRE only supports version numbers. You can manually change REQUIRE when there's a new release, it's not like they're that frequent.

vonDonnerstein commented 6 years ago

Ok, great. Thanks for clarifying. In that case, we should probably check for the version specified in REQUIRE (which can be manually updated when new versions are released) and additionally keep checking for the "release" version - despite the redundancy - to make sure to capture the failing state between the release of a new julia version and the corresponding update of the QuantumLab code. @tkelman Would you have a different suggestion?

Btw, I've just pushed the updated code for julia v0.6 and have updated the .travis.yml and REQUIRE files accordingly (I added comments in both files least I forget to keep them updated in the future).

tkelman commented 6 years ago

Nightly would capture that during the rc period, before "release" is actually doing anything useful. Support for "release" may be removed from Travis' language: julia code.

vonDonnerstein commented 4 years ago

Closing this, since these things are now done in Project.toml instead of REQUIRE anyway.

I've set the required julia version to "1", which should always be the most up-to-date julia version (at least until julia v2.0.0)