search

vonDonnerstein / QuantumLab.jl

A workbench for Quantum Chemistry and Quantum Physics in Julia
Other
51 stars 19 forks source link

don't override display #9

Closed stevengj closed 4 years ago

stevengj commented 6 years ago

You are overloading display in order to customize output. This is the wrong way to do it — see the manual on custom pretty printing.

To customize REPL output, you should override Base.show(io::IO, x::MyType) and/or Base.show(io::IO, ::MIME"text/plain", x::MyType), as explained in the manual.

Overriding display directly will break IJulia, Juno, and other environments that have a custom display mechanism.

vonDonnerstein commented 6 years ago

Thanks for making me aware of this. I hadn't noticed the new section in the manuals. Thank you for clarifying. I will take care of this asap.

vonDonnerstein commented 4 years ago

It's fixed now. Closing