search

vonH / plugin.video.iplayerwww

BBC iPlayer for Kodi
GNU General Public License v2.0
45 stars 24 forks source link

BBCiD is broken #128

Closed primaeval closed 7 years ago

primaeval commented 7 years ago

I received this message about the BBCiD functionality being broken:

The URLs that you use in your signin, signout, and status routines seem to all give http 302 errors. They have new locations: https://www.bbc.com/session, https://www.bbc.com/account.

The segment of code that fails is right here:

def CheckLogin(logged_in): if(logged_in == True or StatusBBCiD() == True): logged_in = True return True elif ADDON.getSetting('bbc_id_enabled') != 'true': xbmcgui.Dialog().ok(translation(30308), translation(30311)) else: attemptLogin = xbmcgui.Dialog().yesno(translation(30308), translation(30312)) if attemptLogin: SignInBBCiD() <----------------------- succeeds if(StatusBBCiD()): <--------------------- fails xbmcgui.Dialog().notification(translation(30308), translation(30309)) logged_in = True; return True; else: xbmcgui.Dialog().notification(translation(30308), translation(30310))

return False

im85288 commented 7 years ago

Hi guys, not sure what is going on but more than happy to make any suggested improvements to keep it from hammering the servers. In fact, ideally I'd like the simple design of my app to be included in this version so everything was native.

Just let me know what's best, cheers.

primaeval commented 7 years ago

I don't think it is a huge problem with Meta4Kodi. It is not as widely used as it was because some of the big name addons have blocked it. I notice it because I have made a few addons that rely on Meta4Kodi and SuperFavourites for catchup using the iPlayer search url and they take longer than necessary because the default search is all pages. http://forum.kodi.tv/showthread.php?tid=282157 http://forum.kodi.tv/showthread.php?tid=267358 http://forum.kodi.tv/showthread.php?tid=284944

CaptainTK commented 7 years ago

Then change your setting, @primaeval. This is back to usage statistics. If we knew that half of our users also use Meta4Kodi, I would be inclined to change the default. If it only affects few users, they can change their setting just as well.

Thanks for getting back so quickly, @im85288. The problem is that your add-on does something that I would describe as a deep scrape or complete scrape of our add-on. That's why you constantly get the progress bar in the upper right corner of your screen when you launch your add-on.

I don't know how to fix that, I must admit that I don't even understand how you invoke this add-on in your code. One year down the road, and I am still not a Python pro.

To be honest, I believe that your GUI approach does not work well with the regular structure of Kodi add-ons as per the examples in the Kodi wiki. Add-ons will always fill one menu level only, while your add-on calls multiple levels at the same time and even dynamically. "Regular" add-ons are much more static in that respect.

On option that comes to my mind would be some special handling of the "Next page" link if the scraper is set to page by page mode. Once this link becomes visible, you would need to execute the underlying code to get more programmes. Currently, "Next page" just shows up as a folder in your GUI. Just set the setting for paginate_episodes to "Page by page" to see what I am referring to.

In order to make your, admittedly beautiful, GUI work well, I believe you would need to change large parts of the plugin.video.iplayerwww code and integrate them directly in your add-on. At the moment, I don't believe your approach is compatible with a "standard" Kodi add-on as this is.

primaeval commented 7 years ago

There might not be so many users of Meta4Kodi but there are a lot of users of SuperFavourites. I just didn't want unnecessary attention being brought to iplayerwww from the BBC as well as the user experience. I thought it was you that wanted the "by page" default in the first place and I talked you out of it. ;) I was wrong.

CaptainTK commented 7 years ago

I got too used to it myself. :-)

ihurst commented 7 years ago

Struggling to get any time on this. For sign out the only thing that currently wirks is deleting cookies.

Not going to be able to look at this till Wednesday.

CaptainTK commented 7 years ago

OK, I'll integrate the deletion of cookies and then release the new version.

Once you have more time, it would still be great if you could look into it again, @ihurst.

Everybody: Please don't be surprised, I will remove the login test script from the master branch again. Otherwise it would be shipped to all users, that makes no sense. I'll most likely branch off a new dev branch to preserve the file.

primaeval commented 7 years ago

Thanks you two for the fix.