search

vonfeng / DeepMove

Codes for WWW'18 Paper-DeepMove: Predicting Human Mobility with Attentional Recurrent Network
GNU General Public License v2.0
143 stars 56 forks source link

Missing indentations #5

Open Einstone-edge opened 5 years ago

Einstone-edge commented 5 years ago

Hi, Jie Sorry to bother you. Your work is excellent, but I have encountered some minor problems when reading the code. At train.py in codes document, when defining generate_input_long_history2, there may be missing an indentation at every line from 145 to 154.

gunarto90 commented 4 years ago

I agree but I think it is not only from 145 to 154 but it is from 145 to 159 because it is quite strange that the variable "i" is referred but it is not inside a loop. If it is designed like that, can the author verify the logic of it? Thank you