search

vonloxley / Shariff-Mediawiki

A mediawiki-extension for Shariff, protecting users privacy.
4 stars 4 forks source link

introduce configuration variable for services #11

Open krabina opened 4 years ago

krabina commented 4 years ago

in reference to https://github.com/vonloxley/Shariff-Mediawiki/issues/5 new configuration parameter $wgShariffServices introduced. Users can override default values with their own desired services.

krabina commented 4 years ago

any news on this?

krabina commented 3 years ago

Hello @vonloxley - lockdowns are a good time to accept PRs :-)

vonloxley commented 3 years ago

No lockdown for me, only work.

vonloxley commented 3 years ago

Thank you very much for this pull-request. I like the new functionality. While I’m sure, that simply writing the service-names into data-services, the documentation states, that it should be An entity-encoded JSON string containing an array of service names to be enabled. Can you please make sure, that the user-input in the new config variable is converted into the required format?

Besides, as I use this code in production, I’d appreciate it, if none of the other defaults (like data-button-style) are changed.

krabina commented 3 years ago

hmm. To be honest, I don't really know what to do. Before the PR it was set fixed to "twitter,facebook,linkedin,print,info", which is not a json string either. I am not really fluent in PHP, so I don't know how to improve this.

Also, I am not messing with data-button-styleafaik, so I also don't know what to do with this requirement.