search

vonovak / react-native-add-calendar-event

Create, view or edit events in react native using the standard iOS / Android dialogs
MIT License
350 stars 102 forks source link

add expo plugin #177

Closed mvanroon closed 1 year ago

mvanroon commented 1 year ago

This pull requests enables the installation of this library in a custom Expo development build.

This way developers can use this package without having to eject their Expo app.

mvanroon commented 1 year ago

@vonovak Yeah I figured, but we've been using this package for years in our app and it still works great. As far as I know, there are currently no alternatives to this library that I know of, right?

Anyway we recently switched to an Expo project so I figured I'd create a pull request.

I still need to test this PR out in an actual implementation, so please hold off with merging/releasing until I've done so.

mvanroon commented 1 year ago

I've tested our fork in both our Android and iOS and everything is working as expected. Merge, release and publish when you're ready!

vonovak commented 1 year ago

thank you!

mvanroon commented 1 year ago

@vonovak Thanks for merging and publishing. Could you also tag master?

vonovak commented 1 year ago

@mvanroon published another with a separate commit and tag

mvanroon commented 1 year ago

@vonovak seems like you published to npm without building the plugin first. This is why I checked in the compiled plugin to GitHub initially. Can you run yarn build:plugin and re-publish and maybe reconsider not ignoring the compiled plugin files?

vonovak commented 1 year ago

done :)

vonovak commented 1 year ago

the plugin files would not be shipped even when included in the repo, they were ignored by npm :)

mvanroon commented 1 year ago

Right! Thanks for the quick fix and publish!