Closed mvanroon closed 1 year ago
@vonovak Yeah I figured, but we've been using this package for years in our app and it still works great. As far as I know, there are currently no alternatives to this library that I know of, right?
Anyway we recently switched to an Expo project so I figured I'd create a pull request.
I still need to test this PR out in an actual implementation, so please hold off with merging/releasing until I've done so.
I've tested our fork in both our Android and iOS and everything is working as expected. Merge, release and publish when you're ready!
thank you!
@vonovak Thanks for merging and publishing. Could you also tag master?
@mvanroon published another with a separate commit and tag
@vonovak seems like you published to npm without building the plugin first. This is why I checked in the compiled plugin to GitHub initially. Can you run yarn build:plugin
and re-publish and maybe reconsider not ignoring the compiled plugin files?
done :)
the plugin files would not be shipped even when included in the repo, they were ignored by npm :)
Right! Thanks for the quick fix and publish!
This pull requests enables the installation of this library in a custom Expo development build.
This way developers can use this package without having to eject their Expo app.